Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve index.html welcome page #1499

Closed
gsmet opened this issue Mar 14, 2019 · 16 comments · Fixed by #37680
Closed

Improve index.html welcome page #1499

gsmet opened this issue Mar 14, 2019 · 16 comments · Fixed by #37680
Assignees
Labels
kind/enhancement New feature or request pinned Issue will never be marked as stale
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Mar 14, 2019

We include in Quarkus a welcome page when creating a new project.

The current file is here: https://github.com/quarkusio/quarkus/blob/master/devtools/maven/src/test/resources/projects/classic/src/main/resources/META-INF/resources/index.html .

It could use some love once we have a logo. @jkbrock could your team take care of it once everything is settled? It's the first thing people will see when creating a new app so I think it deserves to be nice.

@gsmet gsmet added the kind/enhancement New feature or request label Mar 15, 2019
@jkbrock
Copy link

jkbrock commented Mar 15, 2019

@gsmet we'll definitely help. But I have a couple of questions:

  • Is this a patternfly layout?
  • Here's a screenshot rendered from that code, is this what you're displaying now?

Screen Shot 2019-03-15 at 3 41 40 PM

@gsmet
Copy link
Member Author

gsmet commented Mar 15, 2019

I don't think it's a patternfly layout, it's styled very basically (we need all the styles to be embedded so that the user only has to delete one file to get rid of it).

And yes, this is how it looks right now. Thus my request :).

@cescoffier
Copy link
Member

I can't remember how I did it, but I don't believe it uses Patternfly, more some kind on "embedded" CSS. Note that quckstart pages (chat, validation...) uses Patternfly. I'm not against using Patternfly (I love it), but it needs to be embedded in the page as the user may not have internet access (and adding a resource might be a bit too much).

@jkbrock
Copy link

jkbrock commented Mar 18, 2019

Sounds good, I'll take a look and start on some mockups next week.

@gsmet
Copy link
Member Author

gsmet commented Nov 13, 2019

@jkbrock any chance we could try to tackle this soon?

@gsmet gsmet added the pinned Issue will never be marked as stale label Nov 13, 2019
@emmanuelbernard
Copy link
Member

now moved to @insectengine

@brunolmfg
Copy link
Contributor

brunolmfg commented Dec 14, 2020

Maybe a configuration property could be provided to indicate the welcome or index page. This is only possible with undertow extension using the welcome-files entry on web.xml. The vertx-http extension could provide an option like this:

quarkus.http.index-page=/default.html

Open a specific issue for this configuration?

UPDATE: Although it seems unrelated, with #30068 merged, now it is possible to configure the index page.

@insectengine
Copy link
Contributor

@brunolmfg , @gsmet - sorry, this request was before my time. Does this page still need it's visual design addressed?

@cescoffier
Copy link
Member

@insectengine yes, definitely. I did the current one at the very beginning of Quarkus. It can be improved a lot.

@geoand
Copy link
Contributor

geoand commented Aug 30, 2023

Are we still planning on addressing this one?

@insectengine
Copy link
Contributor

Didn't we already address this?

@geoand
Copy link
Contributor

geoand commented Aug 30, 2023

I'll have to check

@geoand
Copy link
Contributor

geoand commented Aug 31, 2023

Is this the updated page?

Screenshot from 2023-08-31 09-30-17

Looks pretty similar to what was reported in this issue. Am I missing something?

@cescoffier
Copy link
Member

No, it had not been addressed...

We had a few ideas with @phillip-kruger, especially when running in dev mode (where we could imagine a dynamic page)

@phillip-kruger
Copy link
Member

Yes, see "Replace the static page on root (/) with a dynamic page created by Dev UI" here: #35178

I do not think this page should be in non-dev mode (test and prod) by default anyway. We can do something that if the use wants it, we create a static file (from a button in dev ui or something)

@phillip-kruger phillip-kruger self-assigned this Dec 12, 2023
@phillip-kruger
Copy link
Member

see #37680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request pinned Issue will never be marked as stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants