Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-90985: Revert "Deprecate passing a message into cancel()" #97999

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Oct 6, 2022

Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.

Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
@gvanrossum gvanrossum merged commit 09de8d7 into python:main Oct 7, 2022
@gvanrossum gvanrossum added the needs backport to 3.11 only security fixes label Oct 7, 2022
@miss-islington
Copy link
Contributor

Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-98006 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
…ythonGH-97999)

Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
(cherry picked from commit 09de8d7)

Co-authored-by: Guido van Rossum <guido@python.org>
@gvanrossum gvanrossum deleted the revert-cancel-msg-deprecation branch October 7, 2022 00:30
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

miss-islington added a commit that referenced this pull request Oct 7, 2022
Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
(cherry picked from commit 09de8d7)

Co-authored-by: Guido van Rossum <guido@python.org>
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
* main:
  pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803)
  pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005)
  Docs: Fix backtick errors found by sphinx-lint (python#97998)
  pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898)
  Remove extra spaces in custom openSSL documentation. (python#93568)
  pythonGH-90985: Revert  "Deprecate passing a message into cancel()" (python#97999)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
…ython#97999)

Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
pablogsal pushed a commit that referenced this pull request Oct 24, 2022
Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
(cherry picked from commit 09de8d7)

Co-authored-by: Guido van Rossum <guido@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants