Clean up old qt_compat aliases #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all aliases to class names, since those were only needed back when those classes were in different modules between Qt 4 and Qt 5 (typically QtGui vs. QtWidgets). With Qt 4 now dropped, Qt 5 and Qt 6 are compatible enough to use the full path to the classes inside our code instead, which makes the wrapper much simpler. This also cleans up some tests doing "QtCore = qt_api.QtCore" or similar, since there were a lot of duplicated but unused such aliases. Seems simpler to me to just use the direct name, even if a bit longer.
The-Compiler
force-pushed
the
qt-compat-cleanup
branch
from
3013f22
to
346f136
Compare
nicoddemus
approved these changes
May 27, 2021
|
Wheee, thanks for all the quick reviews! |
Sure thing, thanks for tackling all this and spearheading the next release. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all aliases to class names, since those were only needed back when those
classes were in different modules between Qt 4 and Qt 5 (typically QtGui vs.
QtWidgets).
With Qt 4 now dropped, Qt 5 and Qt 6 are compatible enough to use the full path
to the classes inside our code instead, which makes the wrapper much simpler.
This also cleans up some tests doing "QtCore = qt_api.QtCore" or similar, since
there were a lot of duplicated but unused such aliases. Seems simpler to me to
just use the direct name, even if a bit longer.
Fixes #354