From 95e43e38564c4823b826deafbbd2b90804d8f71e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Bidoul?= Date: Sun, 31 May 2020 19:52:31 +0200 Subject: [PATCH] Quote 'setup.py install' when calling it legacy We want to make it clear that it is the setup.py install command we consider legacy, not setup.py itself. --- src/pip/_internal/commands/install.py | 4 ++-- src/pip/_internal/wheel_builder.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pip/_internal/commands/install.py b/src/pip/_internal/commands/install.py index 20df6c25ce7..61fe0d9f2b4 100644 --- a/src/pip/_internal/commands/install.py +++ b/src/pip/_internal/commands/install.py @@ -378,8 +378,8 @@ def run(self, options, args): deprecated( reason=( "Could not build wheels for {} which do not use " - "PEP 517. pip will fall back to legacy setup.py " - "install for these.".format( + "PEP 517. pip will fall back to legacy 'setup.py " + "install' for these.".format( ", ".join(r.name for r in legacy_build_failures) ) ), diff --git a/src/pip/_internal/wheel_builder.py b/src/pip/_internal/wheel_builder.py index b5e8bf33924..1214b64a410 100644 --- a/src/pip/_internal/wheel_builder.py +++ b/src/pip/_internal/wheel_builder.py @@ -83,7 +83,7 @@ def _should_build( if not req.use_pep517 and not is_wheel_installed(): # we don't build legacy requirements if wheel is not installed logger.info( - "Using legacy setup.py install for %s, " + "Using legacy 'setup.py install' for %s, " "since package 'wheel' is not installed.", req.name, ) return False