Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to pip-api and update our dependency #24

Closed
woodruffw opened this issue Sep 13, 2021 · 2 comments · Fixed by #27
Closed

Add type hints to pip-api and update our dependency #24

woodruffw opened this issue Sep 13, 2021 · 2 comments · Fixed by #27
Milestone
Stable Release

Comments

@woodruffw
Copy link
Member

Title says it all: this will improve our confidence in our use of pip-api's APIs and will allow us to enable more MyPy features in our own code.
@woodruffw
Copy link
Member Author

In progress here: di/pip-api#97.

@woodruffw woodruffw mentioned this issue Sep 14, 2021
Merged
@woodruffw woodruffw changed the title Add type hints to pip-api Add type hints to pip-api and update our dependency Sep 14, 2021
@woodruffw
Copy link
Member Author

Updated the title to reflect that the changes to pip-api will also require us to bump our minimum required version in setup.py.

@woodruffw woodruffw mentioned this issue Sep 14, 2021
Merged
@di di added this to the Stable Release milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Stable Release
Development

Successfully merging a pull request may close this issue.

setup, pip_audit: bump pip-api, enable MyPy for import pypa/pip-audit
2 participants
@di @woodruffw