Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we separate referencedata to a different package? #324

Open
samwaseda opened this issue Aug 17, 2024 · 3 comments
Open

Can we separate referencedata to a different package? #324

samwaseda opened this issue Aug 17, 2024 · 3 comments

Comments

@samwaseda
Copy link
Member

I would love to use the elastic properties in elaston, but I don’t really need the rest of atomistics there. Can we maybe think about separating it into a different module in pyiron?

@jan-janssen
Copy link
Member

Sure, I am open to that idea. Do you have a suggestion for a package name?

@samwaseda
Copy link
Member Author

samwaseda commented Aug 17, 2024

Maybe it’s a topic to raise for the pyiron meeting because I’m also not really sure how the interface should look, when there are more data sources, some of which might require an API key etc.

This being said, I’m on vacation for 2 weeks so either you guys talk about it or we’ll do it in September when I’m back.

@samwaseda
Copy link
Member Author

For now I simply took it from here. Cf. this PR. But we should definitely think about separating it.

Anyway thanks for implementing this tool. It's super helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants