Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_GetPrefPath should return a c_char_p #135

Closed
benob opened this issue Mar 10, 2019 · 1 comment
Closed

SDL_GetPrefPath should return a c_char_p #135

benob opened this issue Mar 10, 2019 · 1 comment

Comments

@benob
Copy link

benob commented Mar 10, 2019

It currently returns a LP_c_char but it should really return a c_char_p.
Then, the user then has to free it as per the documentation.

@a-hurst a-hurst mentioned this issue Jan 14, 2020
20 tasks
@a-hurst
Copy link
Member

a-hurst commented Jan 15, 2020

Hopefully fixed in the latest commit, thanks for the report! Also, since ctypes is just returning a byte string it's no longer possible to call SDL_free on it (since SDL_free expects a pointer to the character array), but I'd imagine ctypes handles that for us anyway since it's converting the returned array to a string for us.

@a-hurst a-hurst closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants