Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FPDF.write() use _render_styled_cell_text() #340

Closed
Lucas-C opened this issue Feb 7, 2022 · 3 comments · Fixed by #346
Closed

Make FPDF.write() use _render_styled_cell_text() #340

Lucas-C opened this issue Feb 7, 2022 · 3 comments · Fixed by #346

Comments

@Lucas-C
Copy link
Member

Lucas-C commented Feb 7, 2022

In #308, @oleksii-shyman introduced a new FPDF._render_styled_cell_text method.
It should also be used by the FPDF.write method in order to harmonize code.

Unit tests already exist that cover FPDF.write behavior, so this refactoring should be relatively straightforward.

cf. #339 for more context

@harshlancer
Copy link

Can I work on this issue?

@Lucas-C
Copy link
Member Author

Lucas-C commented Feb 7, 2022

Sure @harshlancer, and welcome!

I'm going to assign you this issue to reflect your interest on it.

As a starting point I would recommend that you get a look at the Development documentation page. Maybe start to get the sources with git, install it with pip install -e . and launch the unit tests with pytest.

If you have any questions (on the code, tests, how things work...), feel free to ping me! 😊

@Lucas-C
Copy link
Member Author

Lucas-C commented Feb 24, 2022

Hi @harshlancer !

Have you been able to look at this? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants