Adding find_volume method for compatibility with the DAGMC interface #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay @ebknudsen. I think this should do the trick. Would you mind looking it over too and suggesting any improvements you might see? |
|
roger that - checking... |
|
Looks good to me - and it seems to work as well. One could argue that this kind of bypasses the idea of exposing the MOAB function, but I like the PR. Will merge |
|
Totally fair point. A better long-term fix would be to build a single tree in double down as well. Someday. |
|
Yup someday... amen to that. We (mostly you perhaps :-) ) should do a release/tag of double_down I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.