Chained method calls quite unreadable

[dcramer]

Black version: 18.6b2

I find this vomit-worthy:

--- a/tests/zeus/artifacts/test_checkstyle.py
+++ b/tests/zeus/artifacts/test_checkstyle.py
@@ -12,11 +12,9 @@ def test_result_generation(sample_checkstyle, default_job):
     handler.process(fp)

     results = list(
-        StyleViolation.query.unrestricted_unsafe().filter(
-            StyleViolation.job_id == default_job.id
-        ).order_by(
-            StyleViolation.filename.asc(), StyleViolation.message.asc()
-        )
+        StyleViolation.query.unrestricted_unsafe()
+        .filter(StyleViolation.job_id == default_job.id)
+        .order_by(StyleViolation.filename.asc(), StyleViolation.message.asc())
     )

[dcramer]

Recommendation:

• Keep them newline separated similar to the original (probably hard)
• Indent each follow-up line
• ???

[ambv]

That's intentional and an implementation of #67. Read there for specifics.

Specifically for use like yours (with ORMs), it's cleaner to specify subsequent calls with a leading dot. It's symmetrical to, say, list comprehensions:

results = [
    element
    for element in collection
    if X
    if Y
]

[dcramer]

Ok fine :(

FWIW JS has this everywhere, and anecdotally I believe the standard is indent for following lines and it has made it quite readable.

[ambv]

The indentation in JavaScript is to that you can see where the chain ends. In Python we require parentheses around the call chain so we don't need additional indentation to make it explicit what's going on. We don't indent other operators (+/-/and/or and so on) either.