Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to announcements #340

Closed
4 tasks
jarrydallison opened this issue May 12, 2022 · 2 comments · Fixed by #344
Closed
4 tasks

Minor improvements to announcements #340

jarrydallison opened this issue May 12, 2022 · 2 comments · Fixed by #344
Assignees
Labels
enhancement New feature or request

Comments

@jarrydallison
Copy link
Contributor

Summary

Minor improvements to the new announcements feature

Problem Definition

Feedback has been great, just want to incorporate it.

Proposal

  • Remove extra "X" from the main content holder for announcements. Only use "X" in the datacards
  • Change icon to megaphone or bell (bell is more common)
  • Add hover to menu icons (announcements and login)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jarrydallison jarrydallison added the enhancement New feature or request label May 12, 2022
@jarrydallison jarrydallison self-assigned this May 12, 2022
@ahatzz11
Copy link

ahatzz11 commented May 12, 2022

Regarding the X - How often do we expect announcements to happen? If there's a bunch I think it would be annoying to have to manage each one, maybe on the main content holder there could be a clear all announcements text or something if there is >1 announcement? An alternate clear would avoid the potentially odd double X too. Just a thought!

@jarrydallison
Copy link
Contributor Author

@ahatzz11 I just changed it to have a "Close All" button, no matter how many announcements there are. I think it looks fine and makes sense at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants