From 5bb4b48089165846d93c4a86fde413ba005a9730 Mon Sep 17 00:00:00 2001 From: Benjamin Bock Date: Wed, 7 Dec 2016 19:34:05 +0100 Subject: [PATCH] make type definition of load function userfriendly I know this file is generated, but returning an intersection type is really inconvenient. --- types/protobuf.js.d.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/types/protobuf.js.d.ts b/types/protobuf.js.d.ts index 888731214..7760654ec 100644 --- a/types/protobuf.js.d.ts +++ b/types/protobuf.js.d.ts @@ -322,7 +322,10 @@ declare module "protobufjs" { * @returns {Promise|undefined} A promise if `callback` has been omitted * @throws {TypeError} If arguments are invalid */ - function load(filename: (string|string[]), root?: (Root|any), callback?: any): (Promise|undefined); + function load(filename: (string|string[])): Promise; + function load(filename: (string|string[]), callback: (err: any, root: Root) => any): Object; + function load(filename: (string|string[]), root: Root): Promise; + function load(filename: (string|string[]), root: Root, callback: (err: any, root: Root) => any): Object; /** * Options passed to {@link inherits}, modifying its behavior. @@ -1194,7 +1197,8 @@ declare module "protobufjs" { * @returns {Promise|undefined} A promise if `callback` has been omitted * @throws {TypeError} If arguments are invalid */ - load(filename: (string|string[]), callback?: any): (Promise|undefined); + load(filename: (string|string[])): Promise; + load(filename: (string|string[]), callback: (err: any, root: Root): void; }