Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Message<T> have a default type param #1086

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jul 16, 2018

For context: grpc/grpc-node#425

The type definitions for PB 5/6 are not mutually compatible because of the Message class: one requires that the generic type parameter doesn't exist, while the other one require that it does. As a result, we cannot publish type definitions that are compatible with both.

This PR gives Message<T> a default value for T to work around that. This doesn't relate to any need other than what I described above, so if there is a better way to solve the problem, I would be open to implementing suggestions.

@dcodeIO dcodeIO merged commit 36fc964 into protobufjs:master Jul 17, 2018
@dcodeIO
Copy link
Member

dcodeIO commented Jul 17, 2018

Makes sense, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants