From 6bd758f45d93a1f37e1b4354b8123989005e9924 Mon Sep 17 00:00:00 2001 From: Kurausukun Date: Thu, 6 Jun 2024 23:22:37 -0400 Subject: [PATCH] fix compilation on gcc 14 --- include/util.h | 4 ++-- src/field_effect.c | 8 ++++---- src/trainer_see.c | 2 +- src/util.c | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/util.h b/include/util.h index 8dc5e9bb65..ef1c15faae 100644 --- a/include/util.h +++ b/include/util.h @@ -9,8 +9,8 @@ extern const u8 gMiscBlank_Gfx[]; // unused in Emerald extern const u32 gBitTable[]; u8 CreateInvisibleSpriteWithCallback(void (*)(struct Sprite *)); -void StoreWordInTwoHalfwords(u16 *, unsigned); -void LoadWordFromTwoHalfwords(u16 *, unsigned *); +void StoreWordInTwoHalfwords(u16 *, u32); +void LoadWordFromTwoHalfwords(u16 *, u32 *); int CountTrailingZeroBits(u32 value); u16 CalcCRC16(const u8 *data, u32 length); u16 CalcCRC16WithTable(const u8 *data, u32 length); diff --git a/src/field_effect.c b/src/field_effect.c index 84a4cff885..1707cbd4ae 100644 --- a/src/field_effect.c +++ b/src/field_effect.c @@ -2711,7 +2711,7 @@ static void ShowMonEffect_Outdoors_6(struct Task *task) static void ShowMonEffect_Outdoors_7(struct Task *task) { IntrCallback callback; - LoadWordFromTwoHalfwords((u16 *)&task->data[13], (uintptr_t *)&callback); + LoadWordFromTwoHalfwords((u16 *)&task->data[13], (u32 *)&callback); SetVBlankCallback(callback); ChangeBgX(0, 0, 0); ChangeBgY(0, 0, 0); @@ -2725,7 +2725,7 @@ static void VBlankCB_ShowMonEffect_Outdoors(void) { IntrCallback callback; struct Task *task = &gTasks[FindTaskIdByFunc(Task_ShowMon_Outdoors)]; - LoadWordFromTwoHalfwords((u16 *)&task->data[13], (uintptr_t *)&callback); + LoadWordFromTwoHalfwords((u16 *)&task->data[13], (u32 *)&callback); callback(); SetGpuReg(REG_OFFSET_WIN0H, task->data[1]); SetGpuReg(REG_OFFSET_WIN0V, task->data[2]); @@ -2830,7 +2830,7 @@ static void ShowMonEffect_Indoors_7(struct Task *task) u16 charbase; charbase = (GetGpuReg(REG_OFFSET_BG0CNT) >> 8) << 11; CpuFill32(0, (void *)VRAM + charbase, 0x800); - LoadWordFromTwoHalfwords((u16 *)&task->data[13], (uintptr_t *)&intrCallback); + LoadWordFromTwoHalfwords((u16 *)&task->data[13], (u32 *)&intrCallback); SetVBlankCallback(intrCallback); ChangeBgX(0, 0, 0); ChangeBgY(0, 0, 0); @@ -2845,7 +2845,7 @@ static void VBlankCB_ShowMonEffect_Indoors(void) IntrCallback intrCallback; struct Task *task; task = &gTasks[FindTaskIdByFunc(Task_ShowMon_Indoors)]; - LoadWordFromTwoHalfwords((u16 *)&task->data[13], (uintptr_t *)&intrCallback); + LoadWordFromTwoHalfwords((u16 *)&task->data[13], (u32 *)&intrCallback); intrCallback(); SetGpuReg(REG_OFFSET_BG0HOFS, task->data[1]); SetGpuReg(REG_OFFSET_BG0VOFS, task->data[2]); diff --git a/src/trainer_see.c b/src/trainer_see.c index b66409c18f..5d234adfd3 100644 --- a/src/trainer_see.c +++ b/src/trainer_see.c @@ -518,7 +518,7 @@ static void Task_RevealTrainer_RunTrainerSeeFuncList(u8 taskId) struct ObjectEvent * trainerObj; // another objEvent loaded into by loadword? - LoadWordFromTwoHalfwords((u16 *)&task->data[1], (uintptr_t *)&trainerObj); + LoadWordFromTwoHalfwords((u16 *)&task->data[1], (u32 *)&trainerObj); if (!task->data[7]) { ObjectEventClearHeldMovement(trainerObj); diff --git a/src/util.c b/src/util.c index 5423e0a2da..b327995849 100644 --- a/src/util.c +++ b/src/util.c @@ -120,13 +120,13 @@ u8 CreateInvisibleSpriteWithCallback(void (*callback)(struct Sprite *)) return sprite; } -void StoreWordInTwoHalfwords(u16 *h, unsigned w) +void StoreWordInTwoHalfwords(u16 *h, u32 w) { h[0] = (u16)(w); h[1] = (u16)(w >> 16); } -void LoadWordFromTwoHalfwords(u16 *h, unsigned *w) +void LoadWordFromTwoHalfwords(u16 *h, u32 *w) { *w = h[0] | (s16)h[1] << 16; }