From 38b99f9138268bf01ad7c1cc3c53d3d2a898d64c Mon Sep 17 00:00:00 2001
From: Rebecca Schlussel <rschlussel@fb.com>
Date: Fri, 31 May 2024 11:26:22 -0400
Subject: [PATCH] Set use-new-nan-definition to true by default

---
 .../com/facebook/presto/sql/analyzer/FeaturesConfig.java  | 2 +-
 .../facebook/presto/sql/analyzer/TestFeaturesConfig.java  | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
index bbe8025c031c..c0ce4b7df05a 100644
--- a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
+++ b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
@@ -311,7 +311,7 @@ public class FeaturesConfig
     private CreateView.Security defaultViewSecurityMode = DEFINER;
     private boolean useHistograms;
 
-    private boolean useNewNanDefinition;
+    private boolean useNewNanDefinition = true;
 
     public enum PartitioningPrecisionStrategy
     {
diff --git a/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java b/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java
index b1358226a71a..7328ab507869 100644
--- a/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java
+++ b/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java
@@ -271,8 +271,8 @@ public void testDefaults()
                 .setCteHeuristicReplicationThreshold(4)
                 .setLegacyJsonCast(true)
                 .setPrintEstimatedStatsFromCache(false)
-                .setUseHistograms(false));
-                .setUseNewNanDefinition(false));
+                .setUseHistograms(false)
+                .setUseNewNanDefinition(true));
     }
 
     @Test
@@ -488,7 +488,7 @@ public void testExplicitPropertyMappings()
                 .put("cte-heuristic-replication-threshold", "2")
                 .put("optimizer.print-estimated-stats-from-cache", "true")
                 .put("optimizer.use-histograms", "true")
-                .put("use-new-nan-definition", "true")
+                .put("use-new-nan-definition", "false")
                 .build();
 
         FeaturesConfig expected = new FeaturesConfig()
@@ -702,7 +702,7 @@ public void testExplicitPropertyMappings()
                 .setLegacyJsonCast(false)
                 .setPrintEstimatedStatsFromCache(true)
                 .setUseHistograms(true)
-                .setUseNewNanDefinition(true);
+                .setUseNewNanDefinition(false);
         assertFullMapping(properties, expected);
     }