diff --git a/presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcFilterToSqlTranslator.java b/presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcFilterToSqlTranslator.java index 90f0c786cd31..99c3f87b44d5 100644 --- a/presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcFilterToSqlTranslator.java +++ b/presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcFilterToSqlTranslator.java @@ -38,7 +38,6 @@ import com.facebook.presto.spi.function.FunctionMetadataManager; import com.facebook.presto.spi.relation.CallExpression; import com.facebook.presto.spi.relation.ConstantExpression; -import com.facebook.presto.spi.relation.LambdaDefinitionExpression; import com.facebook.presto.spi.relation.SpecialFormExpression; import com.facebook.presto.spi.relation.VariableReferenceExpression; import com.google.common.base.Joiner; @@ -90,12 +89,6 @@ public TranslatedExpression translateVariable(VariableReferenceE ImmutableList.of()); } - @Override - public TranslatedExpression translateLambda(LambdaDefinitionExpression lambda, Map context, RowExpressionTreeTranslator> rowExpressionTreeTranslator) - { - return untranslated(lambda); - } - @Override public TranslatedExpression translateCall(CallExpression call, Map context, RowExpressionTreeTranslator> rowExpressionTreeTranslator) { diff --git a/presto-bytecode/src/main/java/com/facebook/presto/bytecode/instruction/InvokeInstruction.java b/presto-bytecode/src/main/java/com/facebook/presto/bytecode/instruction/InvokeInstruction.java index ffcd4f7d53e4..b393e567fc62 100644 --- a/presto-bytecode/src/main/java/com/facebook/presto/bytecode/instruction/InvokeInstruction.java +++ b/presto-bytecode/src/main/java/com/facebook/presto/bytecode/instruction/InvokeInstruction.java @@ -416,12 +416,6 @@ public List getBootstrapArguments() return bootstrapArguments; } - @Override - public List getChildNodes() - { - return ImmutableList.of(); - } - @Override public T accept(BytecodeNode parent, BytecodeVisitor visitor) { diff --git a/presto-clickhouse/src/main/java/com/facebook/presto/plugin/clickhouse/optimization/ClickHouseFilterToSqlTranslator.java b/presto-clickhouse/src/main/java/com/facebook/presto/plugin/clickhouse/optimization/ClickHouseFilterToSqlTranslator.java index c1f65e8bff94..b6922599d0f9 100755 --- a/presto-clickhouse/src/main/java/com/facebook/presto/plugin/clickhouse/optimization/ClickHouseFilterToSqlTranslator.java +++ b/presto-clickhouse/src/main/java/com/facebook/presto/plugin/clickhouse/optimization/ClickHouseFilterToSqlTranslator.java @@ -38,7 +38,6 @@ import com.facebook.presto.spi.function.FunctionMetadataManager; import com.facebook.presto.spi.relation.CallExpression; import com.facebook.presto.spi.relation.ConstantExpression; -import com.facebook.presto.spi.relation.LambdaDefinitionExpression; import com.facebook.presto.spi.relation.SpecialFormExpression; import com.facebook.presto.spi.relation.VariableReferenceExpression; import com.google.common.base.Joiner; @@ -90,12 +89,6 @@ public TranslatedExpression translateVariable(VariableRefe ImmutableList.of()); } - @Override - public TranslatedExpression translateLambda(LambdaDefinitionExpression lambda, Map context, RowExpressionTreeTranslator> rowExpressionTreeTranslator) - { - return untranslated(lambda); - } - @Override public TranslatedExpression translateCall(CallExpression call, Map context, RowExpressionTreeTranslator> rowExpressionTreeTranslator) { diff --git a/presto-elasticsearch/src/test/java/com/facebook/presto/elasticsearch/ElasticsearchQueryRunner.java b/presto-elasticsearch/src/test/java/com/facebook/presto/elasticsearch/ElasticsearchQueryRunner.java index dfb273c52eb1..4619ba865073 100644 --- a/presto-elasticsearch/src/test/java/com/facebook/presto/elasticsearch/ElasticsearchQueryRunner.java +++ b/presto-elasticsearch/src/test/java/com/facebook/presto/elasticsearch/ElasticsearchQueryRunner.java @@ -64,7 +64,7 @@ public static DistributedQueryRunner createElasticsearchQueryRunner( queryRunner.installPlugin(new TpchPlugin()); queryRunner.createCatalog("tpch", "tpch"); - TestingElasticsearchConnectorFactory testFactory = new TestingElasticsearchConnectorFactory(); + ElasticsearchConnectorFactory testFactory = new ElasticsearchConnectorFactory(); installElasticsearchPlugin(address, queryRunner, testFactory, extraConnectorProperties); @@ -91,7 +91,7 @@ public static DistributedQueryRunner createElasticsearchQueryRunner( private static void installElasticsearchPlugin( HostAndPort address, QueryRunner queryRunner, - TestingElasticsearchConnectorFactory factory, + ElasticsearchConnectorFactory factory, Map extraConnectorProperties) { queryRunner.installPlugin(new ElasticsearchPlugin(factory)); diff --git a/presto-elasticsearch/src/test/java/com/facebook/presto/elasticsearch/TestingElasticsearchConnectorFactory.java b/presto-elasticsearch/src/test/java/com/facebook/presto/elasticsearch/TestingElasticsearchConnectorFactory.java deleted file mode 100644 index 24667ef6c833..000000000000 --- a/presto-elasticsearch/src/test/java/com/facebook/presto/elasticsearch/TestingElasticsearchConnectorFactory.java +++ /dev/null @@ -1,74 +0,0 @@ -/* - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package com.facebook.presto.elasticsearch; - -import com.facebook.airlift.bootstrap.Bootstrap; -import com.facebook.airlift.json.JsonModule; -import com.facebook.presto.common.type.TypeManager; -import com.facebook.presto.spi.ConnectorHandleResolver; -import com.facebook.presto.spi.NodeManager; -import com.facebook.presto.spi.connector.Connector; -import com.facebook.presto.spi.connector.ConnectorContext; -import com.google.inject.Injector; - -import java.util.Map; - -import static java.util.Objects.requireNonNull; - -class TestingElasticsearchConnectorFactory - extends ElasticsearchConnectorFactory -{ - TestingElasticsearchConnectorFactory() - { - } - - @Override - public String getName() - { - return "elasticsearch"; - } - - @Override - public ConnectorHandleResolver getHandleResolver() - { - return new ElasticsearchHandleResolver(); - } - - @Override - public Connector create(String catalogName, Map config, ConnectorContext context) - { - requireNonNull(catalogName, "catalogName is null"); - requireNonNull(config, "config is null"); - - try { - Bootstrap app = new Bootstrap( - new JsonModule(), - new ElasticsearchConnectorModule(), - binder -> { - binder.bind(TypeManager.class).toInstance(context.getTypeManager()); - binder.bind(NodeManager.class).toInstance(context.getNodeManager()); - }); - - Injector injector = app - .doNotInitializeLogging() - .setRequiredConfigurationProperties(config) - .initialize(); - - return injector.getInstance(ElasticsearchConnector.class); - } - catch (Exception e) { - throw new RuntimeException(e); - } - } -} diff --git a/presto-hive/src/main/java/com/facebook/presto/hive/HiveConnector.java b/presto-hive/src/main/java/com/facebook/presto/hive/HiveConnector.java index ca43a8e26ca3..afc59bc56fea 100644 --- a/presto-hive/src/main/java/com/facebook/presto/hive/HiveConnector.java +++ b/presto-hive/src/main/java/com/facebook/presto/hive/HiveConnector.java @@ -208,12 +208,6 @@ public ConnectorAccessControl getAccessControl() return accessControl; } - @Override - public boolean isSingleStatementWritesOnly() - { - return false; - } - @Override public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly) { diff --git a/presto-hive/src/main/java/com/facebook/presto/hive/pagefile/PageInputFormat.java b/presto-hive/src/main/java/com/facebook/presto/hive/pagefile/PageInputFormat.java index d38aeccae601..059d78cc2a46 100644 --- a/presto-hive/src/main/java/com/facebook/presto/hive/pagefile/PageInputFormat.java +++ b/presto-hive/src/main/java/com/facebook/presto/hive/pagefile/PageInputFormat.java @@ -13,8 +13,6 @@ */ package com.facebook.presto.hive.pagefile; -import org.apache.hadoop.fs.FileSystem; -import org.apache.hadoop.fs.Path; import org.apache.hadoop.io.NullWritable; import org.apache.hadoop.mapred.FileInputFormat; import org.apache.hadoop.mapred.InputSplit; @@ -30,9 +28,4 @@ public RecordReader getRecordReader(InputSplit input { throw new UnsupportedOperationException(); } - - protected boolean isSplitable(FileSystem fs, Path file) - { - return true; - } } diff --git a/presto-hive/src/main/java/com/facebook/presto/hive/parquet/ParquetFileWriter.java b/presto-hive/src/main/java/com/facebook/presto/hive/parquet/ParquetFileWriter.java index 0c83a850290d..de6d9cd89e4c 100644 --- a/presto-hive/src/main/java/com/facebook/presto/hive/parquet/ParquetFileWriter.java +++ b/presto-hive/src/main/java/com/facebook/presto/hive/parquet/ParquetFileWriter.java @@ -156,12 +156,6 @@ public long getValidationCpuNanos() return 0; } - @Override - public Optional getVerificationTask() - { - return Optional.empty(); - } - @Override public long getFileSizeInBytes() { diff --git a/presto-hive/src/test/java/com/facebook/presto/hive/TestEventListenerWithExchangeMaterialization.java b/presto-hive/src/test/java/com/facebook/presto/hive/TestEventListenerWithExchangeMaterialization.java index 62297e310be5..f1e58f6ec782 100644 --- a/presto-hive/src/test/java/com/facebook/presto/hive/TestEventListenerWithExchangeMaterialization.java +++ b/presto-hive/src/test/java/com/facebook/presto/hive/TestEventListenerWithExchangeMaterialization.java @@ -22,7 +22,6 @@ import com.facebook.presto.spi.eventlistener.QueryCompletedEvent; import com.facebook.presto.spi.eventlistener.QueryCreatedEvent; import com.facebook.presto.spi.eventlistener.QueryMetadata; -import com.facebook.presto.spi.eventlistener.SplitCompletedEvent; import com.facebook.presto.tests.DistributedQueryRunner; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; @@ -219,11 +218,6 @@ public void queryCompleted(QueryCompletedEvent queryCompletedEvent) { eventsBuilder.addQueryCompleted(queryCompletedEvent); } - - @Override - public void splitCompleted(SplitCompletedEvent splitCompletedEvent) - { - } } static class EventsBuilder diff --git a/presto-hive/src/test/java/com/facebook/presto/hive/benchmark/FileFormat.java b/presto-hive/src/test/java/com/facebook/presto/hive/benchmark/FileFormat.java index 44fe42c5e37b..0132da278375 100644 --- a/presto-hive/src/test/java/com/facebook/presto/hive/benchmark/FileFormat.java +++ b/presto-hive/src/test/java/com/facebook/presto/hive/benchmark/FileFormat.java @@ -252,12 +252,6 @@ public FormatWriter createFileFormatWriter( } return new PrestoPageFormatWriter(targetFile, compressionCodec); } - - @Override - public boolean supportsDate() - { - return true; - } }, PRESTO_PARQUET { diff --git a/presto-hudi/src/main/java/com/facebook/presto/hudi/HudiSplit.java b/presto-hudi/src/main/java/com/facebook/presto/hudi/HudiSplit.java index c5a6ef4398e7..8c7c4771c027 100644 --- a/presto-hudi/src/main/java/com/facebook/presto/hudi/HudiSplit.java +++ b/presto-hudi/src/main/java/com/facebook/presto/hudi/HudiSplit.java @@ -24,7 +24,6 @@ import java.util.List; import java.util.Optional; -import java.util.OptionalLong; import static com.facebook.presto.spi.schedule.NodeSelectionStrategy.SOFT_AFFINITY; import static com.google.common.base.MoreObjects.toStringHelper; @@ -121,18 +120,6 @@ public Object getInfo() return this; } - @Override - public Object getSplitIdentifier() - { - return this; - } - - @Override - public OptionalLong getSplitSizeInBytes() - { - return OptionalLong.empty(); - } - @JsonProperty @Override public SplitWeight getSplitWeight() diff --git a/presto-jdbc/src/test/java/com/facebook/presto/jdbc/TestJdbcConnection.java b/presto-jdbc/src/test/java/com/facebook/presto/jdbc/TestJdbcConnection.java index 4c11a3112ee1..ed77488e1949 100644 --- a/presto-jdbc/src/test/java/com/facebook/presto/jdbc/TestJdbcConnection.java +++ b/presto-jdbc/src/test/java/com/facebook/presto/jdbc/TestJdbcConnection.java @@ -339,10 +339,6 @@ public void testConnectionProperties() public static class TestNoopQueryInterceptor implements QueryInterceptor { - @Override - public void init(Map properties) - { - } } private Connection createConnection() diff --git a/presto-local-file/src/main/java/com/facebook/presto/localfile/LocalFileMetadata.java b/presto-local-file/src/main/java/com/facebook/presto/localfile/LocalFileMetadata.java index 23f1a0ba6182..9f6cc9d18f2d 100644 --- a/presto-local-file/src/main/java/com/facebook/presto/localfile/LocalFileMetadata.java +++ b/presto-local-file/src/main/java/com/facebook/presto/localfile/LocalFileMetadata.java @@ -21,7 +21,6 @@ import com.facebook.presto.spi.ConnectorTableLayoutHandle; import com.facebook.presto.spi.ConnectorTableLayoutResult; import com.facebook.presto.spi.ConnectorTableMetadata; -import com.facebook.presto.spi.ConnectorViewDefinition; import com.facebook.presto.spi.Constraint; import com.facebook.presto.spi.SchemaTableName; import com.facebook.presto.spi.SchemaTablePrefix; @@ -39,8 +38,6 @@ import static com.facebook.presto.common.type.VarcharType.createUnboundedVarcharType; import static com.facebook.presto.localfile.LocalFileColumnHandle.SERVER_ADDRESS_COLUMN_NAME; import static com.facebook.presto.localfile.LocalFileColumnHandle.SERVER_ADDRESS_ORDINAL_POSITION; -import static java.util.Collections.emptyList; -import static java.util.Collections.emptyMap; import static java.util.Objects.requireNonNull; public class LocalFileMetadata @@ -144,18 +141,6 @@ public Map> listTableColumns(ConnectorSess return columns.build(); } - @Override - public List listViews(ConnectorSession session, String schemaNameOrNull) - { - return emptyList(); - } - - @Override - public Map getViews(ConnectorSession session, SchemaTablePrefix prefix) - { - return emptyMap(); - } - private List listTables(ConnectorSession session, SchemaTablePrefix prefix) { if (prefix.getSchemaName() == null) { diff --git a/presto-main/src/main/java/com/facebook/presto/server/AsyncPageTransportServlet.java b/presto-main/src/main/java/com/facebook/presto/server/AsyncPageTransportServlet.java index 515b7bcd2223..93db9be2a6d4 100644 --- a/presto-main/src/main/java/com/facebook/presto/server/AsyncPageTransportServlet.java +++ b/presto-main/src/main/java/com/facebook/presto/server/AsyncPageTransportServlet.java @@ -257,11 +257,6 @@ public void onFailure(Throwable thrown) responseExecutor); } - @Override - public void destroy() - { - } - @Managed @Nested public TimeStat getReadFromOutputBufferTime() diff --git a/presto-main/src/main/java/com/facebook/presto/util/PowerOfTwoValidator.java b/presto-main/src/main/java/com/facebook/presto/util/PowerOfTwoValidator.java index 08a6847b8add..cdf6ad3f25a7 100644 --- a/presto-main/src/main/java/com/facebook/presto/util/PowerOfTwoValidator.java +++ b/presto-main/src/main/java/com/facebook/presto/util/PowerOfTwoValidator.java @@ -19,11 +19,6 @@ public class PowerOfTwoValidator implements ConstraintValidator { - @Override - public void initialize(PowerOfTwo powerOfTwo) - { - } - @Override public boolean isValid(Integer value, ConstraintValidatorContext context) { diff --git a/presto-main/src/test/java/com/facebook/presto/block/TestInt128ArrayBlock.java b/presto-main/src/test/java/com/facebook/presto/block/TestInt128ArrayBlock.java index 5d854260d2c7..8a2c6b4513ac 100644 --- a/presto-main/src/test/java/com/facebook/presto/block/TestInt128ArrayBlock.java +++ b/presto-main/src/test/java/com/facebook/presto/block/TestInt128ArrayBlock.java @@ -165,12 +165,6 @@ protected boolean isAlignedLongAccessSupported() return true; } - @Override - protected boolean isSliceAccessSupported() - { - return true; - } - @Override protected void assertSlicePosition(Block block, int position, Slice expectedSliceValue) { diff --git a/presto-main/src/test/java/com/facebook/presto/block/TestShortArrayBlock.java b/presto-main/src/test/java/com/facebook/presto/block/TestShortArrayBlock.java index 2e4c5d3b8388..fd9bff8dee20 100644 --- a/presto-main/src/test/java/com/facebook/presto/block/TestShortArrayBlock.java +++ b/presto-main/src/test/java/com/facebook/presto/block/TestShortArrayBlock.java @@ -122,12 +122,6 @@ protected boolean isByteAccessSupported() return false; } - @Override - protected boolean isShortAccessSupported() - { - return true; - } - @Override protected boolean isIntAccessSupported() { diff --git a/presto-main/src/test/java/com/facebook/presto/execution/TestCreateTableTask.java b/presto-main/src/test/java/com/facebook/presto/execution/TestCreateTableTask.java index 0ac0297d0a44..ee0294767ca3 100644 --- a/presto-main/src/test/java/com/facebook/presto/execution/TestCreateTableTask.java +++ b/presto-main/src/test/java/com/facebook/presto/execution/TestCreateTableTask.java @@ -24,12 +24,10 @@ import com.facebook.presto.metadata.ColumnPropertyManager; import com.facebook.presto.metadata.FunctionAndTypeManager; import com.facebook.presto.metadata.TablePropertyManager; -import com.facebook.presto.spi.ColumnHandle; import com.facebook.presto.spi.ColumnMetadata; import com.facebook.presto.spi.ConnectorId; import com.facebook.presto.spi.ConnectorTableMetadata; import com.facebook.presto.spi.PrestoException; -import com.facebook.presto.spi.TableHandle; import com.facebook.presto.spi.connector.ConnectorCapabilities; import com.facebook.presto.spi.constraints.TableConstraint; import com.facebook.presto.spi.security.AllowAllAccessControl; @@ -317,12 +315,6 @@ public List getReceivedTableMetadata() return tables; } - @Override - public void dropColumn(Session session, TableHandle tableHandle, ColumnHandle column) - { - throw new UnsupportedOperationException(); - } - @Override public Set getConnectorCapabilities(Session session, ConnectorId catalogName) { diff --git a/presto-main/src/test/java/com/facebook/presto/operator/exchange/TestLocalExchange.java b/presto-main/src/test/java/com/facebook/presto/operator/exchange/TestLocalExchange.java index 63133d04008f..55552d424a2b 100644 --- a/presto-main/src/test/java/com/facebook/presto/operator/exchange/TestLocalExchange.java +++ b/presto-main/src/test/java/com/facebook/presto/operator/exchange/TestLocalExchange.java @@ -499,17 +499,6 @@ public boolean equals(Object obj) } }), new ConnectorPartitioningHandle() { - @Override - public boolean isSingleNode() - { - return false; - } - - @Override - public boolean isCoordinatorOnly() - { - return false; - } }); PartitionFunction partitionFunction = createPartitionFunction(partitioningProviderManager, session, partitioningHandle, 600, ImmutableList.of(), false); diff --git a/presto-main/src/test/java/com/facebook/presto/sql/planner/TestPredicatePushdownWithDynamicFilter.java b/presto-main/src/test/java/com/facebook/presto/sql/planner/TestPredicatePushdownWithDynamicFilter.java index 395ba33763df..9bf264030f12 100644 --- a/presto-main/src/test/java/com/facebook/presto/sql/planner/TestPredicatePushdownWithDynamicFilter.java +++ b/presto-main/src/test/java/com/facebook/presto/sql/planner/TestPredicatePushdownWithDynamicFilter.java @@ -130,40 +130,6 @@ public void testNonDeterministicPredicateDoesNotPropagateFromFilteringSideToSour tableScan("orders", ImmutableMap.of("ORDERS_ORDER_KEY", "orderkey")))))))); } - @Override - @Test - public void testPredicateFromFilterSideNotPropagatesToSourceSideOfSemiJoinIfNotIn() - { - assertPlan("SELECT quantity FROM (SELECT * FROM lineitem WHERE orderkey NOT IN (SELECT orderkey FROM orders WHERE orderkey > 2))", - anyTree( - semiJoin("LINE_ORDER_KEY", "ORDERS_ORDER_KEY", "SEMI_JOIN_RESULT", - // There should be no Filter above table scan, because we don't know whether SemiJoin's filtering source is empty. - // And filter would filter out NULLs from source side which is not what we need then. - project( - tableScan( - "lineitem", - ImmutableMap.of("LINE_ORDER_KEY", "orderkey", "LINE_QUANTITY", "quantity"))), - anyTree( - filter("ORDERS_ORDER_KEY > BIGINT '2'", - tableScan("orders", ImmutableMap.of("ORDERS_ORDER_KEY", "orderkey"))))))); - } - - @Override - @Test - public void testPredicateFromFilterSideNotPropagatesToSourceSideOfSemiJoinUsedInProjection() - { - assertPlan("SELECT orderkey IN (SELECT orderkey FROM orders WHERE orderkey > 2) FROM lineitem", - anyTree( - semiJoin("LINE_ORDER_KEY", "ORDERS_ORDER_KEY", "SEMI_JOIN_RESULT", - // NO filter here - project(tableScan( - "lineitem", - ImmutableMap.of("LINE_ORDER_KEY", "orderkey"))), - anyTree( - filter("ORDERS_ORDER_KEY > BIGINT '2'", - tableScan("orders", ImmutableMap.of("ORDERS_ORDER_KEY", "orderkey"))))))); - } - @Override public void testDomainFiltersAppliedOnSemiJoinOutputFilterHaveNoImpact() { diff --git a/presto-orc/src/main/java/com/facebook/presto/orc/stream/OrcInputStream.java b/presto-orc/src/main/java/com/facebook/presto/orc/stream/OrcInputStream.java index 167d078f13c5..e0a2cfa4e1bf 100644 --- a/presto-orc/src/main/java/com/facebook/presto/orc/stream/OrcInputStream.java +++ b/presto-orc/src/main/java/com/facebook/presto/orc/stream/OrcInputStream.java @@ -127,12 +127,6 @@ public int available() return length - position; } - @Override - public boolean markSupported() - { - return false; - } - @Override public int read() throws IOException diff --git a/presto-parquet/src/main/java/com/facebook/presto/parquet/reader/ParquetReader.java b/presto-parquet/src/main/java/com/facebook/presto/parquet/reader/ParquetReader.java index facc043f54ae..47fd76bd0c16 100644 --- a/presto-parquet/src/main/java/com/facebook/presto/parquet/reader/ParquetReader.java +++ b/presto-parquet/src/main/java/com/facebook/presto/parquet/reader/ParquetReader.java @@ -453,12 +453,6 @@ public int available() { return (int) (totalSize - readBytes); } - - @Override - public boolean markSupported() - { - return false; - } }; return dataSourceAsStream; } diff --git a/presto-parquet/src/main/java/com/facebook/presto/parquet/writer/PrimitiveColumnWriterV1.java b/presto-parquet/src/main/java/com/facebook/presto/parquet/writer/PrimitiveColumnWriterV1.java index 068a0f3a9970..3d687b42cfac 100644 --- a/presto-parquet/src/main/java/com/facebook/presto/parquet/writer/PrimitiveColumnWriterV1.java +++ b/presto-parquet/src/main/java/com/facebook/presto/parquet/writer/PrimitiveColumnWriterV1.java @@ -31,7 +31,6 @@ import static com.facebook.presto.parquet.writer.ParquetDataOutput.createDataOutput; import static com.facebook.presto.parquet.writer.levels.RepetitionLevelIterables.getIterator; -import static com.google.common.base.Preconditions.checkState; import static java.util.Objects.requireNonNull; import static org.apache.parquet.bytes.BytesInput.copy; @@ -70,14 +69,6 @@ protected void writeDefinitionAndRepetitionLevels(ColumnChunk current) } } - @Override - public List getBuffer() - throws IOException - { - checkState(closed); - return ImmutableList.of(new BufferData(getDataStreams(), getColumnMetaData())); - } - // page header // repetition levels // definition levels diff --git a/presto-parser/src/main/java/com/facebook/presto/sql/parser/AstBuilder.java b/presto-parser/src/main/java/com/facebook/presto/sql/parser/AstBuilder.java index 357de56d940d..5051bb2d069e 100644 --- a/presto-parser/src/main/java/com/facebook/presto/sql/parser/AstBuilder.java +++ b/presto-parser/src/main/java/com/facebook/presto/sql/parser/AstBuilder.java @@ -2102,12 +2102,6 @@ public Node visitNamedArgument(SqlBaseParser.NamedArgumentContext context) // ***************** helpers ***************** - @Override - protected Node defaultResult() - { - return null; - } - @Override protected Node aggregateResult(Node aggregate, Node nextResult) { diff --git a/presto-plugin-toolkit/src/main/java/com/facebook/presto/plugin/base/security/ReadOnlyAccessControl.java b/presto-plugin-toolkit/src/main/java/com/facebook/presto/plugin/base/security/ReadOnlyAccessControl.java index 36fe95560471..def67490ab69 100644 --- a/presto-plugin-toolkit/src/main/java/com/facebook/presto/plugin/base/security/ReadOnlyAccessControl.java +++ b/presto-plugin-toolkit/src/main/java/com/facebook/presto/plugin/base/security/ReadOnlyAccessControl.java @@ -24,20 +24,9 @@ import java.util.Set; -import static com.facebook.presto.spi.security.AccessDeniedException.denyAddColumn; -import static com.facebook.presto.spi.security.AccessDeniedException.denyCreateTable; -import static com.facebook.presto.spi.security.AccessDeniedException.denyCreateView; -import static com.facebook.presto.spi.security.AccessDeniedException.denyDeleteTable; -import static com.facebook.presto.spi.security.AccessDeniedException.denyDropColumn; -import static com.facebook.presto.spi.security.AccessDeniedException.denyDropTable; -import static com.facebook.presto.spi.security.AccessDeniedException.denyDropView; import static com.facebook.presto.spi.security.AccessDeniedException.denyGrantTablePrivilege; -import static com.facebook.presto.spi.security.AccessDeniedException.denyInsertTable; -import static com.facebook.presto.spi.security.AccessDeniedException.denyRenameColumn; -import static com.facebook.presto.spi.security.AccessDeniedException.denyRenameTable; import static com.facebook.presto.spi.security.AccessDeniedException.denyRevokeTablePrivilege; import static com.facebook.presto.spi.security.AccessDeniedException.denyTruncateTable; -import static com.facebook.presto.spi.security.AccessDeniedException.denyUpdateTableColumns; public class ReadOnlyAccessControl implements ConnectorAccessControl @@ -53,36 +42,6 @@ public Set filterSchemas(ConnectorTransactionHandle transactionHandle, C return schemaNames; } - @Override - public void checkCanAddColumn(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName) - { - denyAddColumn(tableName.toString()); - } - - @Override - public void checkCanDropColumn(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName) - { - denyDropColumn(tableName.toString()); - } - - @Override - public void checkCanCreateTable(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName) - { - denyCreateTable(tableName.toString()); - } - - @Override - public void checkCanDropTable(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName) - { - denyDropTable(tableName.toString()); - } - - @Override - public void checkCanRenameTable(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName, SchemaTableName newTableName) - { - denyRenameTable(tableName.toString(), newTableName.toString()); - } - @Override public void checkCanShowTablesMetadata(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, String schemaName) { @@ -94,54 +53,18 @@ public Set filterTables(ConnectorTransactionHandle transactionH return tableNames; } - @Override - public void checkCanRenameColumn(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName) - { - denyRenameColumn(tableName.toString()); - } - @Override public void checkCanSelectFromColumns(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName, Set columnOrSubfieldNames) { // allow } - @Override - public void checkCanInsertIntoTable(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName) - { - denyInsertTable(tableName.toString()); - } - - @Override - public void checkCanDeleteFromTable(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName) - { - denyDeleteTable(tableName.toString()); - } - - @Override - public void checkCanUpdateTableColumns(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName, Set updatedColumns) - { - denyUpdateTableColumns(tableName.toString(), updatedColumns); - } - @Override public void checkCanTruncateTable(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName) { denyTruncateTable(tableName.toString()); } - @Override - public void checkCanCreateView(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName viewName) - { - denyCreateView(viewName.toString()); - } - - @Override - public void checkCanDropView(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName viewName) - { - denyDropView(viewName.toString()); - } - @Override public void checkCanCreateViewWithSelectFromColumns(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName, Set columnNames) { diff --git a/presto-singlestore/src/main/java/com/facebook/presto/plugin/singlestore/SingleStoreClient.java b/presto-singlestore/src/main/java/com/facebook/presto/plugin/singlestore/SingleStoreClient.java index cc56c2a4051f..92800ee7c370 100644 --- a/presto-singlestore/src/main/java/com/facebook/presto/plugin/singlestore/SingleStoreClient.java +++ b/presto-singlestore/src/main/java/com/facebook/presto/plugin/singlestore/SingleStoreClient.java @@ -33,7 +33,6 @@ import java.sql.Connection; import java.sql.DatabaseMetaData; -import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; import java.util.Collection; @@ -93,14 +92,6 @@ public void abortReadConnection(Connection connection) connection.abort(directExecutor()); } - @Override - public PreparedStatement getPreparedStatement(ConnectorSession session, Connection connection, - String sql) - throws SQLException - { - return connection.prepareStatement(sql); - } - @Override protected ResultSet getTables(Connection connection, Optional schemaName, Optional tableName) diff --git a/presto-spi/src/main/java/com/facebook/presto/spi/statistics/RuntimeSourceInfo.java b/presto-spi/src/main/java/com/facebook/presto/spi/statistics/RuntimeSourceInfo.java index 4407f7d80c80..ce4761039411 100644 --- a/presto-spi/src/main/java/com/facebook/presto/spi/statistics/RuntimeSourceInfo.java +++ b/presto-spi/src/main/java/com/facebook/presto/spi/statistics/RuntimeSourceInfo.java @@ -50,10 +50,4 @@ public String getSourceInfoName() { return "Runtime"; } - - @Override - public boolean estimateSizeUsingVariables() - { - return false; - } } diff --git a/presto-testng-services/src/main/java/com/facebook/presto/testng/services/ReportMultiThreadedBeforeOrAfterMethod.java b/presto-testng-services/src/main/java/com/facebook/presto/testng/services/ReportMultiThreadedBeforeOrAfterMethod.java index 4a746c610faa..49fc79d691a4 100644 --- a/presto-testng-services/src/main/java/com/facebook/presto/testng/services/ReportMultiThreadedBeforeOrAfterMethod.java +++ b/presto-testng-services/src/main/java/com/facebook/presto/testng/services/ReportMultiThreadedBeforeOrAfterMethod.java @@ -78,7 +78,4 @@ static void reportMultiThreadedBeforeOrAfterMethod(Class testClass) } } } - - @Override - public void onAfterClass(ITestClass iTestClass) {} }