Implement EIP-1234 #447
Merged
Implement EIP-1234 #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ayrat555
approved these changes
Sep 25, 2018
Summary
=======
This implements EIP-1234 which updates the difficulty calculation and
the block reward for Constantinople.
More details
===========
Thus far we have been using Parity's chain config files to generate
configuration for a chain. We update those files to include the values
for Constantinople.
In this change, however, Parity updates not only some values in the json
configuration but also how they are stored. In particular, the block
rewards and the bomb delay factor can now be a single value or json
objects whose key is the block_number of the fork in question and
the value is the thing looked for. So, for example, we could find this
in a block_reward,
```
block_reward: {
"0" => 300000000,
"1700000" => 2000000
}
```
We make updates to our `Chain` module to account for this.
Update ethereum_common_tests
Run generate_state_tests
We update the state tests with tests that are still failing and the
passing percentages in the main README.
This change also updates chains from parity:
https://github.com/paritytech/parity-ethereum/tree/master/ethcore/res/ethereum
MattMSumner
force-pushed
the
mms-gv-eip-1234
branch
from
3639e1e
to
4024c64
Compare
|
This adds some previously passing tests to the failing tests lists |
This was referenced Sep 26, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #436
Summary
This implements EIP-1234 which updates the difficulty calculation and the block reward for Constantinople.
More details
Thus far we have been using Parity's chain config files to generate configuration for a chain. We update those files to include the values for Constantinople.
In this change, however, Parity updates not only some values in the json configuration but also how they are stored. In particular, the block rewards and the bomb delay factor can now be a single value or json objects whose key is the block_number of the fork in question and the value is the thing looked for. So, for example, we could find this in a block_reward,
We make updates to our
Chainmodule to account for this.