fix: can't open selects inside modals on firefox #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a0a29cc): https://pluralsh-design--pr643-jake-prod-2651-selec-2g1nbiu2.web.app (expires Mon, 30 Sep 2024 18:30:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 784914c934330f8d0a9fd65c68898b3988262b7d |
michaeljguarino
approved these changes
Sep 23, 2024
jsladerman
deleted the
jake/prod-2651-selectdropdown-doesnt-work-on-firefox-looks-like
branch
|
🎉 This PR is included in version 3.69.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not clear why this only happens on firefox, but it has to do with the built-in focus trapping of our modal not playing nice with the current Select component implementation
best workaround to avoid rebuilding the Select component (maybe with radix instead of react aria) for now seems to be just disabling modal focus trapping on firefox. not a huge deal (our old modal didn't really trap focus at all) but ideally we revisit this at some point