Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency in package.json #4207

Closed
wolfd opened this issue Sep 19, 2019 · 1 comment · Fixed by #4208
Closed

Missing dependency in package.json #4207

wolfd opened this issue Sep 19, 2019 · 1 comment · Fixed by #4208
Assignees

Comments

@wolfd
Copy link

wolfd commented Sep 19, 2019

color-rgba should be included in dependencies:

var rgba = require('color-rgba');

I suspect this is a phantom dependency, as it almost certainly exists in a dependency of plotly.js.

@alexcjohnson
Copy link
Collaborator

Oh parcoords... you're quite right:

plotly.js@1.49.4 /Users/alex/plotly/plotly.js
├─┬ color-normalize@1.5.0
│ └── color-rgba@2.1.1 
└─┬ regl-scatter2d@3.1.5
  └── color-rgba@2.1.1  deduped

Now, add it to package.json, or switch the usage to tinycolor2 like we use everywhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants