Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlayController implemented #1225

Merged
merged 1 commit into from
Jun 4, 2018
Merged

PlayController implemented #1225

merged 1 commit into from
Jun 4, 2018

Conversation

sbeigel
Copy link
Contributor

@sbeigel sbeigel commented Mar 24, 2018

WebSocketController has to implement the "new" marker interface PlayController to keep it usable and working.

@asolntsev asolntsev self-assigned this Jun 4, 2018
@asolntsev asolntsev merged commit 57813a0 into playframework:master Jun 4, 2018
@asolntsev
Copy link
Contributor

@sbeigel Thank you for the PR!

@ludofischer
Copy link
Contributor

Is there any possibility of a new Play 1 release with this fix?

@xael-fry
Copy link
Member

@ludovicofischer I will prepare the release for this week

@ludofischer
Copy link
Contributor

@xael-fry That would be awesome, thanks!

@xael-fry xael-fry added this to the 1.5.1 milestone Jul 11, 2018
asolntsev
asolntsev reviewed Jul 13, 2018
View reviewed changes
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ok

@xabolcs xabolcs mentioned this pull request Aug 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asolntsev asolntsev asolntsev left review comments

@xael-fry xael-fry Awaiting requested review from xael-fry

Assignees

@asolntsev asolntsev

Labels
defect
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@sbeigel @asolntsev @ludofischer @xael-fry