Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods marked with @Catch(Throwable.class) catch all Results #1061

Closed
asolntsev opened this issue Dec 26, 2016 · 1 comment
Closed

Methods marked with @Catch(Throwable.class) catch all Results #1061

asolntsev opened this issue Dec 26, 2016 · 1 comment
Assignees
Milestone

Comments

@asolntsev
Copy link
Contributor

PR #963 introduced a bug: now every controller method marked with annotation @Catch(Throwable.class) also catches all Result (e.g. RenderTemplate, Redirect etc.)

We need to fix it. @Catch methods should NOT catch exceptions of class Result.

@asolntsev
Copy link
Contributor Author

This issue was resolved by PR #1062

@xael-fry xael-fry added this to the 1.4.4 milestone Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants