feat: Support alpha colors with Text stroke #10800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add ShaderSystem#maxTextures * use gpu.device.limits.maxSampledTexturesPerShaderStage --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
* feat: reserve texture units for batching * maxTextures instead of reservedTextures --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
* feat: add 'min' and 'max' blend modes * Add visual tests * Fix variable name * replace webgl2 test --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
* add a renderable GC * lint * oops * fix nineslice destroy * fix up PR * tweak times for tests * Update package.json * remove unneeded extension.add call in TextureGCSystem and RenderableGCSystem --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5dcd748:
|
bigtimebuddy
changed the title
Zyie
approved these changes
Jul 29, 2024
Zyie
added
the
✅ Ready To Merge
Zyie
force-pushed
the
dev
branch
2 times, most recently
from
9c9b4eb
to
23656bd
Compare
katmai7
reviewed
Jul 29, 2024
| @@ -14,7 +14,7 @@ export function getCanvasFillStyle( | |||
| { | |||
| if (fillStyle.texture === Texture.WHITE && !fillStyle.fill) | |||
| { | |||
| return Color.shared.setValue(fillStyle.color).toHex(); | |||
| return Color.shared.setValue(fillStyle.color).setAlpha(fillStyle.alpha ?? 1).toHexa(); | |||
There was a problem hiding this comment.
From types, If there is HEXA fillStyle.color but no fillStyle.alpha, isn't opacity always will be 1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10798
This fixes support on stroke for both #RRGGBBAA colors and alpha property uses.
Broken (v8.2.5)
https://jsfiddle.net/bigtimebuddy/gy7dw8mh/
https://jsfiddle.net/bigtimebuddy/gw2vbnc7/
Fixed (PR)
https://jsfiddle.net/bigtimebuddy/b6uztmjd/
https://jsfiddle.net/bigtimebuddy/t3h476x8/