Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check code-style in ipython notebooks #1518

Closed
2 tasks done
menshikh-iv opened this issue Aug 4, 2017 · 2 comments
Closed
2 tasks done

Check code-style in ipython notebooks #1518

menshikh-iv opened this issue Aug 4, 2017 · 2 comments
Labels
testing Issue related with testing (code, documentation, etc)

Comments

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Aug 4, 2017 •
edited
Loading

We do not have any automatic style-checking for notebook, so we need to add it.

  • Look at different variants (nbconvert + flake OR something else (especially for notebooks)).
  • Add this check to travis.
@menshikh-iv menshikh-iv added the testing Issue related with testing (code, documentation, etc) label Aug 4, 2017
@menshikh-iv
Copy link
Contributor Author

So, unfortunately now it's impossible to do it ideally, problems:

  • Many unrelated pep8 errors
  • Unchecked code if you use ipython "magic"
  • Impossible back-mapping (only through Ctrl+F by concrete line)

What's I'll do now

  • Add conversion notebooks to .py
  • Check this .py with flakes (add most popular "spam" PEP8 checks to ignore list)
  • Don't break CI build if something goes wrong, error log only for reading by human

@menshikh-iv menshikh-iv mentioned this issue Sep 4, 2017
Merged
@menshikh-iv
Copy link
Contributor Author

Resolved in #1522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Issue related with testing (code, documentation, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@menshikh-iv