Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redux-saga example in the docs #184

Closed
piotrwitek opened this issue Oct 25, 2019 · 0 comments · Fixed by #186
Closed

Fix redux-saga example in the docs #184

piotrwitek opened this issue Oct 25, 2019 · 0 comments · Fixed by #186

Comments

@piotrwitek
Copy link
Owner

Description

Redux saga example in the docs doesn't work because of a missing line
https://github.com/piotrwitek/typesafe-actions#with-redux-saga-sagas

Suggested solution(s)

function* addTodoSaga(action: ReturnType<typeof fetchTodosAsync.request>): Generator {
  try { // <= this line is missing
    const response: Todo[] = yield call(todosApi.getAll, action.payload);

    yield put(fetchTodosAsync.success(response));
  } catch (err) {
    yield put(fetchTodosAsync.failure(err));
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant