Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commodity and ship market selection marker not cleared #5023

Closed
WKFO opened this issue Nov 25, 2020 · 2 comments · Fixed by #5037
Closed

Commodity and ship market selection marker not cleared #5023

WKFO opened this issue Nov 25, 2020 · 2 comments · Fixed by #5037

Comments

@WKFO
Copy link
Contributor

WKFO commented Nov 25, 2020

Observed behaviour

Commodity market selection marker gets stuck at whatever position it was left at if you switch tabs and come back to the commodity market later.

bug-commodity

Expected behaviour

Remove marker when tabs are switched.

Steps to reproduce

  1. Switch to commodity market tab.
  2. Select a commodity.
  3. Switch to some other tab (for example station lobby).
  4. Switch back to commodity market and scroll around.

My pioneer version (and OS):
28d865b (Win10 x64)

@impaktor
Copy link
Member

I wonder if this bug can be replicated in ship market as well?

@WKFO
Copy link
Contributor Author

WKFO commented Nov 26, 2020

Ship market just selects to the first ship in the list when you switch to the tab. I don't know what would happen if the list has ships when you first switch to the tab, and is empty when you switch to somewhere else and back to it.

EDIT: This happens:
screenshot-20201126-125632

@WKFO WKFO changed the title Commodity selection marker not cleared when tab is switched Commodity and ship market selection marker not cleared Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants