Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: Adding avg indicator to Connection Count in the performance overview. #56102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

metrics: Adding avg indicator to Connection Count in the performance overview. #56102

wants to merge 1 commit into from
+2 −2

Conversation

King-Dylan
Copy link
Contributor

@King-Dylan King-Dylan commented Sep 16, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #56101

Problem Summary:
Adding the avg indicator to Connection Count in the performance overview (compatible with the metrics in TiDB).

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dveeden for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Sep 16, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 16, 2024

Hi @King-Dylan. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow tiprow
Copy link

tiprow bot commented Sep 16, 2024

Hi @King-Dylan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

@King-Dylan I see you adding current indicator, not avg indicator?

@hawkingrei hawkingrei changed the title Adding avg indicator to Connection Count in the performance overview. metrics: Adding avg indicator to Connection Count in the performance overview. Sep 17, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 17, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

@hawkingrei
Copy link
Member

/ok-to-test

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9321%. Comparing base (26443da) to head (5b509a2).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #56102         +/-   ##
=================================================
- Coverage   72.9073%   55.9321%   -16.9752%     
=================================================
  Files          1610       1736        +126     
  Lines        447262     625209     +177947     
=================================================
+ Hits         326087     349693      +23606     
- Misses       101111     251763     +150652     
- Partials      20064      23753       +3689
Flag Coverage Δ
integration 37.1805% <ø> (?)
unit 72.0390% <ø> (+0.0343%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8686% <ø> (+7.0699%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/needs-tests-checked ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement] Adding avg indicator to Connection Count in the performance overview.
2 participants
@King-Dylan @hawkingrei