Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add symfony/yaml ^2.8 to restore PHP 5.4 compatibility #919

Closed
mrook opened this issue May 4, 2018 · 5 comments
Closed

Add symfony/yaml ^2.8 to restore PHP 5.4 compatibility #919

mrook opened this issue May 4, 2018 · 5 comments
Milestone
2.16.2

Comments

@mrook
Copy link
Member

mrook commented May 4, 2018

No description provided.

@mrook mrook added this to the 2.16.2 milestone May 4, 2018
@mrook mrook mentioned this issue May 4, 2018
Merged
@mrook
Copy link
Member Author

mrook commented May 24, 2018

Refs b91d3c3

@XedinUnknown
Copy link

How is it a dev-dependency if the code requires it?

@mrook
Copy link
Member Author

mrook commented Sep 10, 2018

@XedinUnknown the commit you are referring to is part of 3.x, not 2.x. The 2.x version checks for the presence of symfony/yaml (https://github.com/phingofficial/phing/blob/2.16.1/classes/phing/system/io/YamlFileParser.php), 3.x assumes it.

@XedinUnknown
Copy link

Both parser classes, yours and Symfony's, have their main methods as non-static instance methods. Why not inject Symfony's parser instead of assuming or checking for anything?

@mrook
Copy link
Member Author

mrook commented Jan 16, 2019

PHP 5.6 was EOL'ed Dec 31, 2018, so I don't think it makes a lot of sense to spend more time on this.

@mrook mrook closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
2.16.2
Development

No branches or pull requests
2 participants
@mrook @XedinUnknown