Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic path for composer task #701

Merged
merged 29 commits into from Feb 14, 2018
Merged

Dynamic path for composer task #701

merged 29 commits into from Feb 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2017

It would be a nice feature to have the phing composer task check if a composer installation is available to execute the command with if no composer executable path is set.

Copy link
Member

@mrook mrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments:

  • this introduces whitespace changes (we indent using 4 spaces)
  • which is not available on Windows

@mrook
Copy link
Member

mrook commented Mar 24, 2017

Related to #558.

@ghost
Copy link
Author

ghost commented Mar 24, 2017

Would it be a good idea to implement a try catch on the command with the provided composer path and then try finding a path if that fails? That would cover the user entering a wrong path. But then the user would not be aware of that mistake.

@ghost
Copy link
Author

ghost commented Mar 24, 2017

I moved the path check to the getComposer function and cleaned up the class a bit.

@ghost
Copy link
Author

ghost commented Mar 24, 2017

Mind giving me a new review @mrook ?

@mrook
Copy link
Member

mrook commented Mar 29, 2017

Can you squash the commits? The PR is a little noisy this way :)

Anyway:

  • I see a lot of unrelated changes (docblock modifications etc.)
  • Instead of checking against php_uname you can perhaps reuse the host.fstype property

@mrook mrook added this to the 3.0 RC2 milestone Feb 13, 2018
@mrook mrook merged commit d067e5b into phingofficial:master Feb 14, 2018
@mrook mrook modified the milestones: 3.0 RC2, 3.0 RC1 Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant