Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version phing/task-jshint in composer.lock #1639

Closed
MiRacLe-RPZ opened this issue Sep 9, 2021 · 2 comments
Closed

bump version phing/task-jshint in composer.lock #1639

MiRacLe-RPZ opened this issue Sep 9, 2021 · 2 comments
Labels
core
Milestone
3.0.0-RC4

Comments

@MiRacLe-RPZ
Copy link
Contributor

Describe the bug

JsHintTask silently skip checking files if nodejs crashed (in some cases)

Bug was fixed in phingofficial/task-jshint@782d405, but latest phar (3.0.0-RC3) not contains this fix.

Additional context

Also we can add tags phingofficial/task-jshint (for "easy" update in next release cycles)
@mrook
Copy link
Member

mrook commented Sep 9, 2021

It'll be part of RC4. Thanks.

@mrook mrook added this to the 3.0.0-RC4 milestone Sep 9, 2021
@siad007 siad007 added the core label Sep 11, 2021
@mrook
Copy link
Member

mrook commented Sep 16, 2021

Fixed in d482e37.

@mrook mrook closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core
Milestone
3.0.0-RC4
Development

No branches or pull requests
3 participants
@mrook @MiRacLe-RPZ @siad007