Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library images with docker.io defined failed to replace correctly #119

Open
daniel-anova opened this issue Sep 26, 2024 · 0 comments · May be fixed by #120
Open

library images with docker.io defined failed to replace correctly #119

daniel-anova opened this issue Sep 26, 2024 · 0 comments · May be fixed by #120
Labels
bug Something isn't working

Comments

@daniel-anova
Copy link

What happened:

When there a library image with docker.io domain defined the replacement fails.

What you expected to happen:

The image to be replaced correctly like library images without docker.io domain defined

How to reproduce it (as minimally and precisely as possible):

define an image as docker.io/bash:latest

set replacement rule for docker.io and docker.io/library

Anything else we need to know?:

I've submitted a PR with a fix

Environment:

  • Kubernetes version (use kubectl version): `Client Version: v1.29.7; Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3; Server Version: v1.29.7
  • Cloud provider or hardware configuration: Azure AKS
@daniel-anova daniel-anova added the bug Something isn't working label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant