Fatal error during migration

[s-ohnishi]

I did the following for the migration.

vendor/bin/phalcon-migrations run --config=migrations.php

Then the following message is displayed.

Fatal Error: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1' for key 'PRIMARY'

I don't understand it well, so I put
echo __CLASS__,'::',__FUNCTION__,':',__LINE__,PHP_EOL;
in many places and executed it, and the result is as follows.

Phalcon\Migrations\Console\Commands\Migration::run:102
Phalcon\Migrations\Migrations::run:387
Phalcon\Migrations\Mvc\Model\Migration::migrate:317
CompaniesMigration_100::afterCreateTable:115
Phalcon\Migrations\Mvc\Model\Migration::batchInsert:800
/srv/vendor/phalcon/migrations/src/Mvc/Model/Migration.php:903:
string(178) "INSERT INTO companies (id,name,telephone,address,city) VALUES ('1','Acme','31566564','Address','Hello'),('2','Acme Inc ','+44 564612345','Guildhall, PO Box 270, London','London');"
Phalcon\Migrations\Mvc\Model\Migration::migrate:324
CompaniesMigration_100::up:88
Phalcon\Migrations\Mvc\Model\Migration::batchInsert:800
/srv/vendor/phalcon/migrations/src/Mvc/Model/Migration.php:903:
string(178) "INSERT INTO companies (id,name,telephone,address,city) VALUES ('1','Acme','31566564','Address','Hello'),('2','Acme Inc ','+44 564612345','Guildhall, PO Box 270, London','London');"

It seems that afterCreateTable() and up() are called in succession in Migration::migrate.
(each calling batchInsert() )

Is this because these two are defined in companies.php?
Or is it a bug in phalcon/migrations?

[s-ohnishi]

Both methods were also present in other .php files.
As a test, when I commented out each up() and executed it, the migration succeeded.

I'm not sure if this change is appropriate.

[aircodepl]

Done in PR #106

Details: #106 (comment)

[s-ohnishi]

thank you very much.
Good to know that I was not wrong in my thinking.