Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of nf-validation and nf-iridanext #14

Closed
apetkau opened this issue Feb 22, 2024 · 1 comment
Closed

Pin version of nf-validation and nf-iridanext #14

apetkau opened this issue Feb 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@apetkau
Copy link
Member

apetkau commented Feb 22, 2024

Issue

An upcoming upgrade of the nf-validation plugin from 1.1.3 to 2.0.0 will make breaking changes (nextflow-io/plugins#66). Right now, this pipeline uses the latest version of nf-validation and so will stop functioning when this upgrade occurs.

Solution

  1. Pin Nextflow plugin versions
    These should be pinned to specific versions (i.e., change to nf-validation@1.1.3 and nf-iridanext@0.2.0). Pinning nf-iridanext since we might as well pin all plugin versions in this fix.

    snvphylnfc/nextflow.config

    Lines 166 to 170 in 0ac17cb

    // Nextflow plugins
    plugins {
    id 'nf-validation' // Validation of pipeline parameters and creation of an input channel from a sample sheet
    id 'nf-iridanext' // Output for IRIDA Next
    }
  2. Update version
    Update version to indicate a bug fix to 2.0.1:
    version = '2.0.0'
  3. Update CHANGELOG.md to list the change. https://github.com/phac-nml/snvphylnfc/blob/dev/CHANGELOG.md
@apetkau
Copy link
Member Author

apetkau commented Feb 28, 2024

Fixed in #15

@apetkau apetkau closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant