fix(gatsby-theme-docz): use options from gatsby-config #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zainxyz
reviewed
Mar 5, 2019
| @@ -17,7 +17,7 @@ const touchTemplateWithPaths = paths => async (filepath, opts) => { | |||
| await touch(dest, raw) | |||
| } | |||
|
|
|||
| module.exports = async opts => { | |||
| module.exports = async (_ opts) => { | |||
There was a problem hiding this comment.
Shouldn't this be async (_, opts) => { instead?
Missing the , (comma / period).
There was a problem hiding this comment.
Yes, yes it should. Fixed!
The gatsby-node `onPreInit` hook passes in two arguments, the _second_ of which is the plugin options.
lettertwo
force-pushed
the
fix-v1-gatsby-theme-docz-gatsby-config-options
branch
from
0b7c779
to
61e862e
Compare
pedronauck
approved these changes
Mar 12, 2019
|
thanks @lettertwo, really... btw, did you testing v1? |
|
Yes! Using v1 alpha in a project. I’ve got a few temporary hax in place to make it work, but it’s early days on the project, so I’m planning to keep up to date with the v1 progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a PR against the v1 branch
Description
The gatsby-node
onPreInithook passes in two arguments, the second of which is the plugin options.This fixes merging of options defined for gatsby-theme-docz in a project's
gatsby-config.js.