fix(docz-theme-default): prop table header background was overflowing #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronauck
approved these changes
Oct 27, 2018
pedronauck
pushed a commit
that referenced
this pull request
Oct 27, 2018
* Update the PropsTable to conditionally include the description column. * Adds a description to the Alert component in the basic examples to demonstrate it being added * The Button component in the basic example has no descriptions to demonstrate it being excluded * Remove a data- attribute that was used for testing * feat(docz): render [Empty String] on PropsTable (#427) * Updates the PropsTable to render '[Empty String]' instead of nothing. * Add the code to print [No Default] * fix(docz-theme-default): prop table header background was overflowing (#421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header background was peeking over the border-radius of the table, only on the largest breakpoint. In my testing, it seems like you want to leave overflow-x there for small screens.
Screenshots
Before:
After:
