Conditionally include the Description column for the PropsTable component #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2018 17:43
* Adds a description to the Alert component in the basic examples to demonstrate it being added * The Button component in the basic example has no descriptions to demonstrate it being excluded
* Updates the PropsTable to render '[Empty String]' instead of nothing. * Add the code to print [No Default]
pedronauck
approved these changes
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When generating docs for an internal project with the window made narrow. I was running out of space for the
PropsTablecomponent when no descriptions were present for that component. It didn't appear that there was a flag available for this and after thinking about it I decided this wasn't necessary since it could be inferred if this should be included.Review
Screenshots
This was tested and appears to be functional based on all the checks specified in the contributing guide.