Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docz-core): use of src config in edit button link #186

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

bpetetot
Copy link
Contributor

@bpetetot bpetetot commented Aug 3, 2018

Description

In version 0.9.2, when I have a src different from ./ in the .doczrc.js file, the edit button doesn't have the correct link address. The src is missing in the link.

For example:
With the following configuration:

#.doczrc.js
export default {
  src: './src',
  port: 3001,
}

A mdx file in myrepo/src/components/button/button.mdx

Then the edit button will go to:

https://github.com/xxx/myrepo/components/button/button.mdx

instead of:

https://github.com/xxx/myrepo/src/components/button/button.mdx

In this PR, I add the missing part of the link using the src config parameter.

@pedronauck pedronauck merged commit 553f90c into doczjs:master Aug 3, 2018
@pedronauck
Copy link
Member

Great @bpetetot, thank the pr, I'm merging it right now 🙏

@bpetetot bpetetot deleted the bug/edit-link branch August 4, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants