From 1760a4a5e63df6d157245a652fe14c772c354e9c Mon Sep 17 00:00:00 2001 From: Peter Fern Date: Sun, 15 Aug 2021 23:21:59 +1000 Subject: [PATCH] fix(logging): Include collector in warning for unsupported properties --- collector/dataset.go | 2 +- collector/pool.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/collector/dataset.go b/collector/dataset.go index 4052b43..e3db8c9 100644 --- a/collector/dataset.go +++ b/collector/dataset.go @@ -216,7 +216,7 @@ func (c *datasetCollector) updateDatasetMetrics(ch chan<- metric, pool string, d for k, v := range dataset.Properties { prop, err := datasetProperties.find(k) if err != nil { - _ = level.Warn(c.log).Log(`msg`, propertyUnsupportedMsg, `help`, helpIssue, `property`, k, `err`, err) + _ = level.Warn(c.log).Log(`msg`, propertyUnsupportedMsg, `help`, helpIssue, `collector`, c.kind, `property`, k, `err`, err) } if err = prop.push(ch, v, labelValues...); err != nil { return err diff --git a/collector/pool.go b/collector/pool.go index 8f7b062..36e3eb3 100644 --- a/collector/pool.go +++ b/collector/pool.go @@ -148,7 +148,7 @@ func (c *poolCollector) updatePoolMetrics(ch chan<- metric, pool string) error { for k, v := range p.Properties { prop, err := poolProperties.find(k) if err != nil { - _ = level.Warn(c.log).Log(`msg`, propertyUnsupportedMsg, `help`, helpIssue, `property`, k, `err`, err) + _ = level.Warn(c.log).Log(`msg`, propertyUnsupportedMsg, `help`, helpIssue, `collector`, `pool`, `property`, k, `err`, err) } if err = prop.push(ch, v, labelValues...); err != nil { return err