fix(logging): Include collector in warning for unsupported properties

pdf · Aug 18, 2021 · 1760a4a · 1760a4a
1 parent 5d5c6eb
commit 1760a4a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/collector/dataset.go b/collector/dataset.go
@@ -216,7 +216,7 @@ func (c *datasetCollector) updateDatasetMetrics(ch chan<- metric, pool string, d
 	for k, v := range dataset.Properties {
 		prop, err := datasetProperties.find(k)
 		if err != nil {
-			_ = level.Warn(c.log).Log(`msg`, propertyUnsupportedMsg, `help`, helpIssue, `property`, k, `err`, err)
+			_ = level.Warn(c.log).Log(`msg`, propertyUnsupportedMsg, `help`, helpIssue, `collector`, c.kind, `property`, k, `err`, err)
 		}
 		if err = prop.push(ch, v, labelValues...); err != nil {
 			return err

diff --git a/collector/pool.go b/collector/pool.go
@@ -148,7 +148,7 @@ func (c *poolCollector) updatePoolMetrics(ch chan<- metric, pool string) error {
 	for k, v := range p.Properties {
 		prop, err := poolProperties.find(k)
 		if err != nil {
-			_ = level.Warn(c.log).Log(`msg`, propertyUnsupportedMsg, `help`, helpIssue, `property`, k, `err`, err)
+			_ = level.Warn(c.log).Log(`msg`, propertyUnsupportedMsg, `help`, helpIssue, `collector`, `pool`, `property`, k, `err`, err)
 		}
 		if err = prop.push(ch, v, labelValues...); err != nil {
 			return err