Skip to content
This repository has been archived by the owner on Dec 24, 2019. It is now read-only.

DismissAfter is hardcoded in notification stack #43

Closed
juliogarciag opened this issue Jan 13, 2016 · 2 comments
Closed

DismissAfter is hardcoded in notification stack #43

juliogarciag opened this issue Jan 13, 2016 · 2 comments
Labels
bug Unexpected behavior or broken functionality

Comments

@juliogarciag
Copy link

When using the stack like this:

const notifications = [
  {
    key: 1,
    message: "Some Message",
    dismissAfter: 10000
  }
]

<NotificationStack
  notifications={notifications} />

The dismissAfter property is always 2000. I found here:

https://github.com/pburtchaell/react-notification/blob/master/src/notificationStack.js#L23

that the dismissAfter property is not being honored when the property is passed to stacked notification and the 2000 values is hardcoded.

@pburtchaell pburtchaell added the bug Unexpected behavior or broken functionality label Jan 14, 2016
@pburtchaell
Copy link
Owner

Thanks for bringing this to my attention. I am happy to fix it but I will be unavailable to do so for the next few weeks—busy with work and returning to school. If you are willing to make a PR, that would be great! 😄

@pburtchaell
Copy link
Owner

This is fixed in react-notification@4.2.0. Thanks to @sergiofm for the PR. 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Unexpected behavior or broken functionality
Projects
None yet
Development

No branches or pull requests

2 participants