You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
then, i wanted to get some CI set up to upload build stats for all our new commits on master. so I wrote a ghaction workflow to do that: paulirish/lighthouse#57
For push, I'm currently using yarn bt-cli upload-build directly, but it would be really nice to make this action able to work for any stage that an action can run at.
as you can tell i'm adopting bundletracker for Lighthouse. :)
we were using bundlesize but it's terrible and i hate it.
the first priority is to get the historical trendlines of our build sizes. I managed to iterate through 18 months of git history and upload all those builds:
https://lh-build-tracker.herokuapp.com/builds/limit/1000
then, i wanted to get some CI set up to upload build stats for all our new commits on master. so I wrote a ghaction workflow to do that: paulirish/lighthouse#57
However, the build-tracker-action basically expects to only run
on: pull_request
, it appears.(from https://github.com/paulirish/lighthouse/runs/520463822)
It's erroring on
context.payload.pull_request
.For whatever reason I didn't think a workflow that's
on: pull_request
would run on push to master, but... does it?The text was updated successfully, but these errors were encountered: