Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflecting tokio-service -> tower-service dependency change? #562

Closed
jnpkrn opened this issue Jun 28, 2020 · 1 comment
Closed

Reflecting tokio-service -> tower-service dependency change? #562

jnpkrn opened this issue Jun 28, 2020 · 1 comment

Comments

@jnpkrn
Copy link

jnpkrn commented Jun 28, 2020

[originally, I thought that tokio-service is not amongst dependencies,
the point was that I've made said rename locally and forgot about actual
usages, and only later figured out what's going on]

Is this upstream rename/migration of that project suitable for being reflected?

See tokio-rs/tokio-service#32

There are some changes in API as well, sadly, e.g.:

error[E0107]: wrong number of type arguments: expected 1, found 0
  --> tcp/src/service.rs:24:37
   |
24 | impl<M: Metadata, S: Middleware<M>> tower_service::Service for Service<M, S> {
   |                                     ^^^^^^^^^^^^^^^^^^^^^^ expected 1 type argument
@jnpkrn jnpkrn changed the title Dependency on tokio_service not declared Reflecting tokio-service -> tower-service dependency change? Jun 28, 2020
@tomusdrw
Copy link
Contributor

The whole library for now is using futures=0.1 and that means tokio-service. See #485 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants