Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Logging Service #25

Closed
tjcouch-sil opened this issue Feb 13, 2023 · 5 comments · Fixed by #64 or #76
Closed

Create Logging Service #25

tjcouch-sil opened this issue Feb 13, 2023 · 5 comments · Fixed by #64 or #76
Assignees

Comments

@tjcouch-sil
Copy link
Member

tjcouch-sil commented Feb 13, 2023

We need to add a logging service so we stop using console.whatever all the time. Apparently we already have some kind of electron-specific logging library. Let's use it!

Some discussion on the topic: https://github.com/paranext/paranext-core/pull/24/files#r1103914506

One important place is in ServerNetworkConnector.onClientConnect

@irahopkinson
Copy link
Contributor

irahopkinson commented Mar 9, 2023

@tjcouch-sil built the app and encountered this error:

Image

@irahopkinson irahopkinson reopened this Mar 9, 2023
@irahopkinson
Copy link
Contributor

In logger.ts, I tried:

  • log.initialize({ preload: true }); but that didn't change anything.
  • require('electron-log/renderer'); from the client but that didn't change anything either.

@irahopkinson
Copy link
Contributor

@tjcouch-sil From my shallow clone of the electron-react-boilerplate repo (which is where this repo is started from) I added a branch with minimal reproduction of our logger.ts but the production build didn't have the issue. To me this indicates (as you suggested) that it's something about our webpack config that we have changed.

@irahopkinson
Copy link
Contributor

Moved the win-unpacked folder up the tree to see the whole of the message:

Image

@irahopkinson irahopkinson linked a pull request Mar 14, 2023 that will close this issue
@tjcouch-sil
Copy link
Member Author

tjcouch-sil commented Mar 15, 2023

Extension host is having the same problem with not being able to find the electron-log-preload module. Will create a PR soon.

EDIT: This was closed during sprint 3 review, so I will just make a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants