Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Info pattern #125

Closed
tjcouch-sil opened this issue Apr 3, 2023 · 0 comments · Fixed by #156 or #159
Closed

Remove Info pattern #125

tjcouch-sil opened this issue Apr 3, 2023 · 0 comments · Fixed by #156 or #159
Assignees
@lyonsil

Comments

@tjcouch-sil
Copy link
Member

NetworkObjectInfo and DataProviderInfo is an annoying api that is already confusing people. Let's just accept that we will be modifying objects when making them into NetworkObjects and layer over their dispose and onDidDispose methods.
@tjcouch-sil tjcouch-sil added this to the External Extension Ready milestone Apr 3, 2023
@lyonsil lyonsil self-assigned this Apr 14, 2023
@lyonsil lyonsil linked a pull request Apr 21, 2023 that will close this issue
Update the network object service to modify the objects passed in #156
Merged
@lyonsil lyonsil linked a pull request Apr 26, 2023 that will close this issue
Remove "info" from data provider and network object names #159
Merged
@lyonsil lyonsil reopened this Apr 26, 2023
@tjcouch-sil tjcouch-sil mentioned this issue Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyonsil lyonsil

Labels
None yet
Projects
Paranext
Status: ✅ Done
Milestone
No milestone
2 participants
@tjcouch-sil @lyonsil