Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix breaking typescript@next tests #3914

Closed
jkillian opened this issue May 15, 2018 · 2 comments
Closed

Fix breaking typescript@next tests #3914

jkillian opened this issue May 15, 2018 · 2 comments

Comments

@jkillian
Copy link
Contributor

jkillian commented May 15, 2018

Bug Report

  • TSLint version:
  • TypeScript version:
  • Running TSLint via: (pick one) CLI / Node.js API / VSCode / grunt-tslint / Atom / Visual Studio / etc

microsoft/TypeScript#24142 is the cause of one of the issues, we should wait for a response there, hopefully a new nightly version of TS will resolve this issue.

Another test failure was caused by a new diagnostic which marks when all destructured elements are unused. We'll likely need to make a code change to handle this:

image

@jkillian
Copy link
Contributor Author

Update: microsoft/TypeScript#24142 has been fixed, so after the next nightly is released we should see some of the issues resolve themselves. This just means we'll need to appropriately handle the new diagnostics noted above

@johnwiseheart
Copy link
Contributor

I'm pretty sure theyre fixed now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants