Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chaining API is inconsistent across the codebase #2119

Closed
rcchen opened this issue May 20, 2015 · 4 comments
Closed

Chaining API is inconsistent across the codebase #2119

rcchen opened this issue May 20, 2015 · 4 comments
Labels
Domain: API Design

Comments

@rcchen
Copy link
Contributor

rcchen commented May 20, 2015

Currently blocking on the following TypeScript issues
@aicioara
Copy link
Contributor

aicioara commented Jul 8, 2015

@rcchen is this still valid?

@aicioara
Copy link
Contributor

aicioara commented Jul 8, 2015

Can you point to the code base ?

@rcchen
Copy link
Contributor Author

rcchen commented Jul 9, 2015

Still valid; the easiest repro for this is chaining a method for a parent class on a subclass.

Example: new Plottable.Plots.Rectangle().x().x2()..

If .x() were not explicitly defined on Plots.Rectangle, .x2() would not work.

This is an open issue on Typescript as has been referenced above.

@aicioara aicioara mentioned this issue Jul 24, 2015
Open
@aicioara
Copy link
Contributor

Closing as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: API Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcchen @aicioara