Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strict-staged builders #282

Open
sfackler opened this issue Jan 6, 2024 · 0 comments · Fixed by #346
Open

Add strict-staged builders #282

sfackler opened this issue Jan 6, 2024 · 0 comments · Fixed by #346

Comments

@sfackler
Copy link
Member

sfackler commented Jan 6, 2024

We currently support panicking and staged builders. We should remove support for the panicking ones since they're a bit dangerous, and add support for "strict staged" builders a la conjure-java where we don't special case collections.

This should allow us to remove all of the codegen in this crate in favor of the staged-builder crate.
@sfackler sfackler mentioned this issue Apr 21, 2024
Merged
@sfackler sfackler changed the title Remove non-staged builders and add strict-staged. Add strict-staged builders Apr 21, 2024
@sfackler sfackler reopened this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove fallible builders palantir/conjure-rust
1 participant
@sfackler