Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve requestFilter documentation #703

Open
TimothyJones opened this issue Jun 24, 2021 · 0 comments
Open

Improve requestFilter documentation #703

TimothyJones opened this issue Jun 24, 2021 · 0 comments
Labels
documentation Indicates a need for improvements or additions to documentation enhancement Indicates new feature requests

Comments

@TimothyJones
Copy link
Contributor

The verifier spins up a proxy server for the provider, which is how we implement requestFilters and stateHandlers.

However, we don't explain this anywhere, so people don't know that requestFilters are a bit of express middleware. We should explain this.

Relatedly, I don't think that we warn if stateHandlers and stateChangeUrl are both set in the options (if stateChangeUrl is set, then stateHandlers will be ignored).
@mefellows mefellows added enhancement Indicates new feature requests documentation Indicates a need for improvements or additions to documentation labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Indicates a need for improvements or additions to documentation enhancement Indicates new feature requests
Projects
Pact Triage (not yet in use)
Status: New Issue
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mefellows @TimothyJones