Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run builds on Windows #297

Closed
mefellows opened this issue Jun 8, 2023 · 4 comments
Closed

chore: Run builds on Windows #297

mefellows opened this issue Jun 8, 2023 · 4 comments

Comments

@mefellows
Copy link
Member

This was disabled in 2.x.x for reasons I can't remember now. This should shake out any issues with pact-go install and obviously create more reliability.

@YOU54F
Copy link
Member

YOU54F commented Jul 13, 2023

I assume windows and macos builds don't run due to lack of Docker in GitHub actions on those platforms

Appveyor windows build has been failing, I believe it's due to the pact-cli being unable to communicate with docker via localhost.

@YOU54F
Copy link
Member

YOU54F commented Jul 13, 2023

I was able to get macos running on arm64 linux and macos via Cirrus CI

test_task_template: &TEST_TASK_TEMPLATE
  modules_cache:
    fingerprint_script: cat go.sum
    folder: $GOPATH/pkg/mod
  deps_script: make deps
  clean_script: make clean
  bin_script: make bin
  test_script: make test

linux_test_task:
  env:
    matrix:
      - VERSION: 1.17
      - VERSION: 1.18
  name: Tests (Go $VERSION)
  container:
    image: golang:$VERSION
  <<: *TEST_TASK_TEMPLATE

linux_arm64_test_task:
  env:
    matrix:
      - VERSION: 1.17
      - VERSION: 1.18
  name: Tests (Go $VERSION)
  arm_container:
    image: golang:$VERSION
  <<: *TEST_TASK_TEMPLATE

macos_arm64_test_task:
  macos_instance:
    image: ghcr.io/cirruslabs/macos-ventura-base:latest
  pre_req_script: brew install gox
  <<: *TEST_TASK_TEMPLATE

lint_task:
  name: GolangCI Lint
  container:
    image: golangci/golangci-lint:latest
  run_script: golangci-lint run -v --out-format json > lint-report.json
  always:
    golangci_artifacts:
      path: lint-report.json
      type: text/json
      format: golangci

@mefellows
Copy link
Member Author

Nice one - thanks! I can't recall the specifics as to why now, but you could well be right.

@YOU54F YOU54F mentioned this issue Oct 2, 2023
@YOU54F
Copy link
Member

YOU54F commented Jul 31, 2024

Fixed by #443

@YOU54F YOU54F closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants