Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usermanagement Search is inconsistent / confusing #7613

Closed
tbsbdr opened this issue Sep 8, 2022 · 6 comments · Fixed by #7599
Closed

Usermanagement Search is inconsistent / confusing #7613

tbsbdr opened this issue Sep 8, 2022 · 6 comments · Fixed by #7599
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 8, 2022

Steps to reproduce

  1. login as admin, goto usermgnt
  2. type "ma"
  3. list in background filters for "ma" ✅, preview offers option "Search users", but closes the preview on click of "search users" or <enter>
  4. preview visually blocks user from the filtered resultlist 

Screenshot 000481@2x

Expected behaviour

Short term for GA:

Longterm (not part of this issue):

Actual behaviour

  • "Search users" closes the preview but does not search or alike
  • preview visually blocks user from the filtered resultlist
@tbsbdr tbsbdr added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker labels Sep 8, 2022
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Sep 8, 2022

@kulmann would you agree on the proposal?

after discussion with @janackermann this issue also aims to get rid of the searchprovider-selection especially when it comes to files search. thats why I would rate it as p2. I'd like to have a nice files-search

@kulmann
Copy link
Member

kulmann commented Sep 8, 2022

Agreed 👍

@AlexAndBear
Copy link
Contributor

@tbsbdr THX for the write down

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Sep 8, 2022

Implementation is here:
#7599

image

@tbsbdr please let me know if you want to change the: 'Widht (currently 1/4 of viewport)', 'Label', 'Default text', 'Description message'
documented here https://owncloud.design/#/oC%20Components/OcTextInput

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Sep 9, 2022

nice. and nice nightshift 😳

I'd prefer to have a reasonable fixed width of ex. 16 rem (224px). 

Why would I prefer a fixed width? We should make sure that the form has 1 ) a min-width - it shouldn't get too small and 2 ) a max-width because short filter-terms like "albert" make a faulty impression in too long forms. So let's just have it fixed.

'Label', 'Default text', 'Description message' fine as is 👍

@AlexAndBear
Copy link
Contributor

THX, implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants