Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move personal quota fetching to a sane location #7093

Closed
kulmann opened this issue Jun 7, 2022 · 1 comment
Closed

Move personal quota fetching to a sane location #7093

kulmann opened this issue Jun 7, 2022 · 1 comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Jun 7, 2022

As followup of #7053, where it surfaced during review:

We currently fetch the quota of the personal storage while loading the personal space. As above mentioned PR allows to query different personal spaces (based on backend side permissions), it makes less sense to keep querying the quota in the folder loader task, since it might not even be the own personal space (i.e. quota information unavailable to the logged in user).

We need to look into a more sane place to query the backend for personal space quota. Since the quota of the personal space is displayed in the user menu from the web-runtime package we should at least move it closer to that component (i.e. not files app, but runtime).


Just FYI / context, which is already covered by a different ticket: #6930
Apart from the low hanging fruit we need to decide when and how we want to update the personal space quota:

  1. after any successful write-request (copy, move, delete, restore, upload, file modification via an editor, ...)
    a. by re-calculating the quota information in the frontend code
    b. by re-querying the quota information from the backend
  2. as a background job with rather low frequency (same as notifications, which also might need a lower request frequency)
@kulmann kulmann added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Jun 7, 2022
@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 27, 2022

duplicate of #6930 (note decision)

@tbsbdr tbsbdr closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants